Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CM S5048 driver to the correct folder #123

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

omajoshi
Copy link
Contributor

Rename qcodes_contrib_drivers/drivers/CMTS5048.py to qcodes_contrib_drivers/drivers/CopperMountain/S5048.py

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #123 (b664d1a) into master (78839ee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   19.49%   19.49%           
=======================================
  Files         121      121           
  Lines       14448    14448           
=======================================
  Hits         2816     2816           
  Misses      11632    11632           
Impacted Files Coverage Δ
...es_contrib_drivers/drivers/CopperMountain/S5048.py 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall the old .py file be left in its original location with a deprecation warning and importing all the public items (e.g. driver class) from the new .py file?

@jenshnielsen jenshnielsen changed the title Moves the driver to the correct folder Moves S5048 driver to the correct folder Nov 15, 2022
@jenshnielsen jenshnielsen changed the title Moves S5048 driver to the correct folder Move CM S5048 driver to the correct folder Nov 15, 2022
@jenshnielsen jenshnielsen merged commit b66e611 into QCoDeS:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants